Fix flaky pipe auto split IT#17756
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
luoluoyuyu
approved these changes
May 27, 2026
Member
luoluoyuyu
left a comment
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review summary
Replaces brittle assertions (exactly two pipes in a fixed order) with assertAutoSplitResult, which matches auto-split behavior when the history pipe may already be dropped after snapshot transfer.
Looks good to merge.
| // The history pipe may have already been auto-dropped after snapshot transfer completes. | ||
| Assert.assertTrue( | ||
| showPipeResult.stream().anyMatch(i -> Objects.equals(i.id, pipeName + "_realtime"))); | ||
| Assert.assertFalse(showPipeResult.stream().anyMatch(i -> Objects.equals(i.id, pipeName))); |
Member
There was a problem hiding this comment.
nit: Assert.assertFalse(showPipeResult.stream().anyMatch(...)) can be written as assertTrue(showPipeResult.stream().noneMatch(i -> Objects.equals(i.id, pipeName))) for readability. Not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
IoTDBPipeAutoSplitIT assumes that auto split always leaves both history and realtime pipes visible immediately after creation. In practice, the history snapshot pipe can finish and be auto-dropped very quickly when there is no historical data, so SHOW PIPE may only return the realtime pipe and the test fails with expected 2 but was 1.
Modifications
Tests